Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only skip first n lines in the first chunk and don't take the first line as header (#1045) #1046

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Only skip first n lines in the first chunk and don't take the first line as header (#1045) #1046

wants to merge 2 commits into from

Conversation

jkruke
Copy link

@jkruke jkruke commented Mar 7, 2024

References #1045

pokoli
pokoli requested changes Mar 12, 2024
View reviewed changes
tests/test-cases.js Show resolved Hide resolved
papaparse.js Outdated Show resolved Hide resolved
@foobarnes
Copy link

@jkruke @pokoli Is this ready to merge? Can I do any work on it to get it through? Pretty essentially on our end.

@jkruke
Copy link
Author

jkruke commented Apr 21, 2024 •
edited

Actually, the reviewer @pokoli should re-review my actions regarding to his comments
From my point of view, no further work needs to be done then

@foobarnes
Copy link

@pokoli Any update here?

@jkruke
Copy link
Author

jkruke commented May 19, 2024

To get this done, maybe @foobarnes you wanna approve+merge this PR instead? :)

@foobarnes
Copy link

My bad, didn't realize I had permissions!

@jkruke jkruke requested a review from pokoli May 23, 2024 13:11
@jkruke
Copy link
Author

jkruke commented May 23, 2024

Hmm it's still not mergable because of unapproved changes, can we approve them somehow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foobarnes foobarnes foobarnes approved these changes

@pokoli pokoli Awaiting requested review from pokoli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jkruke @foobarnes @pokoli @kikelkik