Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev/0.3.2 #422

Merged
merged 31 commits into from Apr 29, 2024
Merged

Dev/0.3.2 #422

merged 31 commits into from Apr 29, 2024

Conversation

peterrrock2
Copy link
Collaborator

This is the main PR for release 0.3.2.

Main Changes

  • Added SingleMetricOptimizer and Gingleator classes so that we can run short-burst, simulated annealing, and tilted runs
    • Added documentation with examples on how to work with all of these
  • Fixed major bug in the way that find_balance_edge_cuts_memoization and find_balance_edge_cuts_contration work. Now you must specify if you are intending to cut off a single epsilon-balanced district via a one-sided-cut or if you intend to split into two epsilon-balanced districts.
    • This primarily affected the gerrychain.tree.recursive_tree_part and gerrychain.tree.recursive_seed_part_inner functions.
    • There is now a bespoke epsilon_tree_bipartition function that deals with the case where we would like to split a subgraph into two epsilon-balanced districts.
  • Updated the way that the region-aware code works so that we also up weight things that do not belong to any specified regions
  • Updated the documentation for region-aware and improved the installation/reproducibility instructions
  • Provided fix for Graph.from_geodataframe() fails without crs #417

jenni-niels and others added 30 commits July 28, 2021 18:25
…ased number of Gingles' districts; add further documentation SingleMetricOptimizer class methods; delint optimization.py
…partitions and to store rolling best partition/score as instance variables.
…xpose `best_part`, `best_score`, and `score` as readonly properties. Add stubs for new cycling beta functions.
Thank you all for your work on this! We will be adding this in version 0.3.2.
Copy link
Contributor

@cdonnay cdonnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great Peter! I think I only have spelling/doc strings comments.

docs/repeated_subsections/reproducible_envs.rst Outdated Show resolved Hide resolved
docs/topics/reporting.rst Outdated Show resolved Hide resolved
docs/topics/reporting.rst Outdated Show resolved Hide resolved
docs/user/data.rst Show resolved Hide resolved
docs/user/geometries.rst Show resolved Hide resolved
gerrychain/optimization/optimization.py Outdated Show resolved Hide resolved
gerrychain/optimization/optimization.py Show resolved Hide resolved
gerrychain/tree.py Outdated Show resolved Hide resolved
gerrychain/tree.py Outdated Show resolved Hide resolved
gerrychain/tree.py Show resolved Hide resolved
Copy link
Contributor

@cdonnay cdonnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

@peterrrock2 peterrrock2 merged commit 6c9fb6b into main Apr 29, 2024
1 check passed
@peterrrock2 peterrrock2 deleted the dev/0.3.2 branch April 29, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants