Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#414 Use method in recursive calls to recursive_seed_part_inner #415

Merged
merged 11 commits into from Oct 4, 2023

Conversation

mkarrmann
Copy link
Contributor

See #414 for description of issue.

The solution is self-explanatory.

@mkarrmann
Copy link
Contributor Author

Something weird is going on with pip install in CI, will have to investigate later...

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #415 (3a3db2a) into main (a35f7cc) will decrease coverage by 0.14%.
Report is 2 commits behind head on main.
The diff coverage is 85.24%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #415      +/-   ##
==========================================
- Coverage   89.00%   88.87%   -0.14%     
==========================================
  Files          39       39              
  Lines        1774     1789      +15     
==========================================
+ Hits         1579     1590      +11     
- Misses        195      199       +4     
Files Coverage Δ
gerrychain/chain.py 88.63% <100.00%> (+1.13%) ⬆️
gerrychain/grid.py 74.11% <100.00%> (+0.30%) ⬆️
gerrychain/metagraph.py 95.00% <100.00%> (+0.55%) ⬆️
gerrychain/partition/assignment.py 95.77% <100.00%> (+0.06%) ⬆️
gerrychain/accept.py 55.55% <75.00%> (+5.55%) ⬆️
gerrychain/graph/graph.py 91.17% <92.30%> (+0.05%) ⬆️
gerrychain/tree.py 81.29% <66.66%> (-1.20%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04ff4f9...3a3db2a. Read the comment docs.

@mkarrmann
Copy link
Contributor Author

Not sure what's going on with codecov, I'm clearly not decreasing test coverage here.

@mkarrmann
Copy link
Contributor Author

@InnovativeInventor @pjrule FYI, a very simple bug fix. A unit test to test the change is included.

@InnovativeInventor InnovativeInventor self-assigned this Oct 4, 2023
Copy link
Member

@InnovativeInventor InnovativeInventor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes make sense to me.

I'm not sure why codecov is being weird about this and flagging those lines in particular. Maybe something changed in codecov?

tests/test_tree.py Outdated Show resolved Hide resolved
@InnovativeInventor InnovativeInventor linked an issue Oct 4, 2023 that may be closed by this pull request
@mkarrmann mkarrmann changed the title #414 Use method is recursive calls to recursive_seed_part_inner #414 Use method in recursive calls to recursive_seed_part_inner Oct 4, 2023
@InnovativeInventor InnovativeInventor merged commit 1b8430d into mggg:main Oct 4, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

recursive_seed_part_inner does not respect provided method
2 participants