Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: switch to html5_polyglot writer #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP: switch to html5_polyglot writer #66

wants to merge 1 commit into from

Conversation

mgedmin
Copy link
Owner

@mgedmin mgedmin commented Jan 10, 2023

Because readme-rendering switched to it, so I'm using it already in effect, in a half-assed way which causes problems like issue #65.

Current status:

  • unit tests fail
  • the CSS rendering inside the body is still broken
  • I'm not sure I like the default stylesheet change
  • this is more work than I expected

@mgedmin
WIP: switch to html5_polyglot writer
8e1c462 
Because readme-rendering switched to it, so I'm using it already in
effect, in a half-assed way which causes problems like issue #65.
@mgedmin
Copy link
Owner Author

mgedmin commented Jan 10, 2023

the CSS rendering inside the body is still broken

I think this is because of my hack that tries to insert the pygments style as a <style> element inside the <body>, which is now getting cleaned, which makes the <style> wrapper disappear.

I don't remember why I did it that way instead of somehow sticking the extra styles inside <head>.

I sill have no idea why this causes problems only when .. contents: is added to the ReST source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
help-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mgedmin