Change MIME media type to image/svg+xml for interactive mode #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
text/svg+xml isn't a standard mediatype at all so I've changed it to image/svg+xml which is defined in the w3 https://www.w3.org/TR/SVG/mimereg.html
|
I can confirm that this fixes display inFirefox. Reported in the Wikimedia phabricator: https://phabricator.wikimedia.org/T279991 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
text/svg+xml isn't a standard media type at all so I've changed it to image/svg+xml which is defined in the w3 https://www.w3.org/TR/SVG/mimereg.html
Steps to reproduce
Create one in interactive mode:
{{#drawio:Test|interactive}}Let it display in the browser (FF, Safari doesn't show anything) - Chrome works
Fix
After applying the fix the charts get displayed in FF, Safari and Chrome