Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: support name #88

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feat: support name #88

wants to merge 2 commits into from

Conversation

agoose77
Copy link
Contributor

No description provided.

@agoose77
Copy link
Contributor Author

I'm fairly new to Sphinx, but I think this is reasonable.

@mgaitan
Copy link
Owner

mgaitan commented Sep 1, 2022

name is to define the "id" element of the block, right? I guess it should be handle via forcing the figure wrapper, like with caption. Then the id= will be the one of the figure container, keeping the inner mermaid id for the js lib.

Could you check how is the html looking and maybe add a test?

@agoose77
Copy link
Contributor Author

agoose77 commented Nov 21, 2022

I just got back to this. I don't think mermaid-js needs a special ID, so this shouldn't confuse things?

@psychemedia
Copy link

Does the :name: element proposed by this PR act in a similar way to the name element that is used in eg MyST Figure elements, and which supports things like {numref} generated references against the :name: identifier?

If so, this would be really useful to have accepted.

@mgaitan
Copy link
Owner

mgaitan commented Sep 12, 2023

@agoose77 could you update the PR? or could somebody else?

@christiangrett
Copy link

That would be a nice feature! Are there still open tasks for this PR or can the PR be merged?

@mgaitan
Copy link
Owner

mgaitan commented May 22, 2024

@christiangrett could you rebase this in a new one so it can be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants