Attribute sets dev #219
Open
Attribute sets dev #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshiraiwa
added
in-test-with-mfem-master
sshiraiwa
added
in-test-with-mfem-master
There was a problem hiding this comment.
I am still trying to better understand SWIG so I apologize if these are basic questions:
- Does having import statements inside of the function affect performance? (is it okay to move
...import IsoparametricTransformationoutside of the functions)? - Since these are all almost the same function can we have one function, e.g.
GetTransformation(), and all these other functions just compose on-top of it? Not sure how different this is in a*.ivs*.pyfile. - What does
$action(self, i, Tr)do?
There was a problem hiding this comment.
Perhaps moving the import statement out of the functions may help performance issues noted in #216
There was a problem hiding this comment.
This is from https://www.swig.org/Doc4.2/SWIGDocumentation.html.
$action** is will be replaced by the call to the C/C++ proper method. Note that this does not include the arguments to the C/C++ method.
I will see what can be done with import statement.
justinlaughlin
approved these changes
Apr 22, 2024
justinlaughlin
added
the
in-test-with-mfem-master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add
attribute_sets.hpp and arrays_by_name.hpp wrapper
minor fix of ex5p mentioned in Install fails on MacOS:
chrpathnot found #213removed bilininteg_ext.i and lininteg_ext.i from git tracking
note ArraysByName::begin and ArraysByName::end (STL-like iterator) are ignored for now