UseShellExecute analyzer #707
Draft
+448
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meziantou
reviewed
Mar 30, 2024
| { | ||
| public void Test() | ||
| { | ||
| [||]Process.Start("notepad"); |
There was a problem hiding this comment.
I'm not sure to understand why it should be reported. UseShellExecute is only useful when you want to redirect input/output. This method doesn't redirect output, so why do you need to report it?
There was a problem hiding this comment.
Because it has a different default value between .NET Framework an .NET core.
Co-authored-by: Gérald Barré <meziantou@users.noreply.github.com>
jairbubbles
force-pushed
the
useshellexecute-analyzer
branch
from
ae3a538
to
bf255a2
Compare
jairbubbles
force-pushed
the
useshellexecute-analyzer
branch
from
bf255a2
to
6d3a1a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's probably the number 1 issue I've seen between .NET Framework and .NET Core so I thought that an analyzer might be helpful. Let me know what you think and I'll dig more.