Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow API domain to be specified #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nlively
Copy link
Contributor

@nlively nlively commented Sep 10, 2018

For BambooHR customers outside the USA, such as those in the UK, allow the API domain to be specified when initializing the client.

The Bamboozled.client() initializer method now takes a api_domain parameter along with the others. An example of a valid value here would be api.bamboohr.co.uk.

If no api_domain parameter has been specified, it defaults to api.bamboohr.com.

@splybon splybon changed the base branch from master to develop February 19, 2019 14:07
@splybon splybon changed the base branch from develop to master February 20, 2019 13:47
@splybon
Copy link
Contributor

splybon commented Feb 20, 2019

Hey @nlively thanks so much for the PR and sorry it's taken so long to get back to you, we've changed who is responsible for this repo.

Can you make some updates to it?

  1. Rebase off of or merge in the develop branch to this one (I think there may be conflicts due to linting changes)
  2. Run rubocop against this. There were some updates that we did on the develop branch
  3. Change this PR from merging into master, to merge into develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants