-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Locking timeout #24
Open
anton-iskryzhytskyi
wants to merge
5
commits into
metarhia:master
Choose a base branch
from
anton-iskryzhytskyi:locking-timeout
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Locking timeout #24
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b46ab15
feat: locking timeout
anton-iskryzhytskyi 07c7387
fix: remove timeout from Lock and add it to Lock.queue element
anton-iskryzhytskyi f9099d4
refactor: add the clear timeout logic
anton-iskryzhytskyi 364e6b7
refactor: move errors to separate file
anton-iskryzhytskyi ed212e4
feat: clean timeout timer on abort, throw error on timeout
anton-iskryzhytskyi File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
'use strict'; | ||
|
||
class AbortError extends Error { | ||
constructor(message) { | ||
super(message); | ||
this.name = 'AbortError'; | ||
} | ||
} | ||
|
||
class TimeoutError extends Error { | ||
constructor(message) { | ||
super(message); | ||
this.name = 'TimeoutError'; | ||
} | ||
} | ||
|
||
module.exports = { | ||
AbortError, | ||
TimeoutError, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,6 +8,7 @@ const tests = [ | |
'deadlock', | ||
'recursive-deadlock', | ||
'thread-main', | ||
'lock-time', | ||
]; | ||
|
||
(async () => { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
'use strict'; | ||
|
||
const assert = require('assert').strict; | ||
const { locks } = require('..'); | ||
const { sleep } = require('./test-utils.js'); | ||
const { TimeoutError } = require('../errors.js'); | ||
|
||
module.exports = async () => { | ||
await (async () => { | ||
const caseName = 'Should release a resource after timeout deadline'; | ||
const startTs = Date.now(); | ||
|
||
await locks | ||
.request('LockTime', { timeout: 100 }, async () => { | ||
await sleep(200); | ||
}) | ||
.catch(() => {}); | ||
|
||
const isCaseSuccess = Date.now() - startTs < 200; | ||
assert.strictEqual(isCaseSuccess, true, caseName); | ||
})(); | ||
|
||
await (async () => { | ||
const caseName = 'Should release a resource and throw the TimeoutError'; | ||
let error; | ||
|
||
await locks | ||
.request('LockTime', { timeout: 100 }, async () => { | ||
await sleep(200); | ||
}) | ||
.catch(err => (error = err)); | ||
|
||
const isCaseSuccess = error instanceof TimeoutError; | ||
assert.strictEqual(isCaseSuccess, true, caseName); | ||
})(); | ||
|
||
await (async () => { | ||
const caseName = 'Should release a resource after handler complete a task'; | ||
const startTs = Date.now(); | ||
|
||
await locks.request('LockTime', { timeout: 200 }, async () => { | ||
await sleep(100); | ||
}); | ||
|
||
const isCaseSuccess = Date.now() - startTs < 200; | ||
assert.strictEqual(isCaseSuccess, true, caseName); | ||
})(); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
'use strict'; | ||
|
||
const sleep = msec => | ||
new Promise(resolve => { | ||
setTimeout(resolve, msec); | ||
}); | ||
|
||
module.exports = { | ||
sleep, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.