feat: implement insert/update/delete builders #39
Conversation
|
looks like you forgot to execute |
lib/select-builder.js
Outdated
| const { makeParamValue } = require('./query-builder'); | ||
| const { checkTypeOrQuery, mapJoinIterable } = require('./utils'); | ||
| const { QueryConditionsBuilder } = require('./query-conditions-builder'); |
lib/select-builder.js
Outdated
| return mapJoinIterable( | ||
| from, | ||
| f => (typeof f === 'string' ? f : `${f.table} AS ${f.alias}`), | ||
| f => (!f.alias ? String(f.table) : `${f.table} AS ${f.alias}`), |
There was a problem hiding this comment.
Don't we use arrow-parens: always ?
There was a problem hiding this comment.
Oops, looks like i mixed up styles. Will update.
lib/update-builder.js
Outdated
| } | ||
|
|
||
| build() { | ||
| let query = 'UPDATE'; |
There was a problem hiding this comment.
Maybe: query = []; .push, push, .join ?
There was a problem hiding this comment.
I prefer to avoid array-join unnecessarily.
lib/utils.js
Outdated
| @@ -30,9 +31,19 @@ const joinIterable = (val, sep) => { | |||
| return res; | |||
| }; | |||
|
|
|||
| const checkTypeOrQuery = (value, name, type) => { | |||
| if (!(value instanceof QueryBuilder) && typeof value !== type) { | |||
There was a problem hiding this comment.
It seems to me we need OR logic here: !instance || !type
There was a problem hiding this comment.
No, this is "exit condition" for error cases.
lib/delete-builder.js
Outdated
| this.operations = { | ||
| from: null, | ||
| }; |
There was a problem hiding this comment.
| this.operations = { | |
| from: null, | |
| }; | |
| this.operations = { from: null }; |
There was a problem hiding this comment.
In line 16 we have one-liner
lib/delete-builder.js
Outdated
| } | ||
|
|
||
| build() { | ||
| let query = 'DELETE'; |
There was a problem hiding this comment.
Maybe: query = []; .push, push, .join ?
lib/delete-builder.js
Outdated
| build() { | ||
| let query = 'DELETE'; | ||
|
|
||
| const from = this.operations.from; |
There was a problem hiding this comment.
| const from = this.operations.from; | |
| const { from } = this.operations; |
lib/delete-builder.js
Outdated
| if (!from) { | ||
| throw new Error('Cannot generate SQL, tableName is not defined'); | ||
| } | ||
| query += String(from.table) + (from.alias ? `AS ${from.alias}` : ''); |
There was a problem hiding this comment.
Looks like from.table will be string already
| query += String(from.table) + (from.alias ? `AS ${from.alias}` : ''); | |
| const alias = from.alias ? `AS ${from.alias}` : ''; | |
| query += `$from.table $alias`; |
lundibundi
changed the title
No description provided.