Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo and add await for res.json() #255

Closed
wants to merge 3 commits into from
Closed

Fix typo and add await for res.json() #255

wants to merge 3 commits into from

Conversation

timursevimli
Copy link
Member

  • tests and linter show no problems (npm t)
  • tests are added/updated for bug fixes and new features
  • code is properly formatted (npm run fmt)
  • description of changes is added in CHANGELOG.md
  • update .d.ts typings

tshemsedinov pushed a commit that referenced this pull request May 22, 2024
@timursevimli @tshemsedinov
Fix typo
a622018 
PR-URL: #255
tshemsedinov pushed a commit that referenced this pull request May 22, 2024
@timursevimli @tshemsedinov
Add await for res.json()
d2922ff 
PR-URL: #255
tshemsedinov pushed a commit that referenced this pull request May 22, 2024
@timursevimli @tshemsedinov
Remove useless async
d4cb478 
PR-URL: #255
@tshemsedinov
Copy link
Member

Landed in a622018, d2922ff, and d4cb478

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tshemsedinov tshemsedinov tshemsedinov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timursevimli @tshemsedinov