Fix Content-length on httpApiCall #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timursevimli
force-pushed
the
fix-custom-headers
branch
from
f3eb0a4
to
f1f1564
Compare
|
I agree with you and I don't really like this approach either, but then we won't be able to test it |
timursevimli
force-pushed
the
fix-custom-headers
branch
from
d72c8ef
to
837e26b
Compare
tshemsedinov
reviewed
Mar 8, 2024
lib/network.js
Outdated
| if (body) headers['Content-Length'] = Buffer.byteLength(body); | ||
| const options = { method, headers: custom, body }; | ||
| return await fetch(url, options).then(async (res) => { | ||
| headers['Content-Type'] = mimeType; |
There was a problem hiding this comment.
This will change incoming arguments
tshemsedinov
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#234
npm t)npm run fmt)