WIP: Add allSettled mode for Collector class #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axbuglak
reviewed
Dec 15, 2023
lib/collector.js
Outdated
| this.keys = keys; | ||
| this.isRejectable = isRejectable; |
There was a problem hiding this comment.
We should check if isRejectable is boolean
| @@ -88,6 +106,13 @@ class Collector { | |||
| } | |||
| } | |||
|
|
|||
| function getSettled(err = null, value = null) { | |||
There was a problem hiding this comment.
It shouldn't be a separate function, it should be inside a class Collector. And what must do this function? Function set takes the argument value not as an object.
There was a problem hiding this comment.
I made getSettled as static method in class Collector before, but @tshemsedinov said said that the function is better.
Function should return an object like Promise.allSettled() depending on whether the result is "fulfilled" or "rejected".
|
I do not remember the purpose of all this stuff, please send me link to video and more explanations in private messages @basi1iscus Thanks! |
|
Also need to rebase on master |
tshemsedinov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm t)npm run fmt)