Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timeout in memoize after which cache will cleared #462

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

timeout in memoize after which cache will cleared #462

wants to merge 2 commits into from

Conversation

Jhon-Mosk
Copy link

@Jhon-Mosk Jhon-Mosk commented Nov 13, 2023 •
edited

  • tests and linter show no problems (npm t)
  • tests are added/updated for bug fixes and new features
  • code is properly formatted (npm run fmt)

tshemsedinov
tshemsedinov requested changes Nov 14, 2023
View reviewed changes
Copy link
Member

@tshemsedinov tshemsedinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting timeout multiple times will generate multiple timers

@Jhon-Mosk
bugfix memoize timeout
0c94eba 
Setting timeout multiple times will generate multiple timers
@Jhon-Mosk
Copy link
Author

@tshemsedinov я поправил

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tshemsedinov tshemsedinov tshemsedinov requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jhon-Mosk @tshemsedinov