Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code style config and fix eslint: consistent-return #458

Closed
wants to merge 4 commits into from
Closed

Fix code style config and fix eslint: consistent-return #458

wants to merge 4 commits into from

Conversation

timursevimli
Copy link
Member

  • tests and linter show no problems (npm t)
  • tests are added/updated for bug fixes and new features
  • code is properly formatted (npm run fmt)

@tshemsedinov tshemsedinov changed the title Updated dependencies and code style Package maintenance Jul 14, 2023
tshemsedinov
tshemsedinov approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@tshemsedinov tshemsedinov left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM without 73dbd81 and d656f03

lib/async-iterator.js
Comment on lines +70 to +71
foundValue = value;
break;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to revert

@tshemsedinov tshemsedinov changed the title Package maintenance Fix code style config and fix eslint: consistent-return Jul 14, 2023
tshemsedinov pushed a commit that referenced this pull request Jul 14, 2023
@timursevimli @tshemsedinov
Update eslint-config-metarhia, prettier and eslint
3afbc3b 
PR-URL: #458
tshemsedinov pushed a commit that referenced this pull request Jul 14, 2023
@timursevimli @tshemsedinov
Fix code style applying eslint: consistent-return
2f64120 
PR-URL: #458
@tshemsedinov
Copy link
Member

Landed in 3afbc3b and 2f64120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tshemsedinov tshemsedinov tshemsedinov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timursevimli @tshemsedinov