-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client (on server) tests for example interface #204
Open
leonpolak
wants to merge
16
commits into
master
Choose a base branch
from
client-tests
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
3399aaa
Initial tests for server side Client
leonpolak d0cfb5e
Tests for most of the example rpc calls
leonpolak b1ff004
Tests for example interface
leonpolak e1220f5
Initial tests for server side Client
leonpolak f1e5d4d
Tests for most of the example rpc calls
leonpolak f866e65
Tests for example interface
leonpolak 924bbc9
Apply suggestions from code review
tshemsedinov 6138196
Subscription and redis tests
tshemsedinov 149e0ae
Apply prettier
tshemsedinov d41efdd
Fix linter
tshemsedinov 5118524
Run client test
tshemsedinov 64c06d2
Merge branch 'client-tests' of https://github.com/metarhia/Example in…
leonpolak b8d4b8f
Trying to force tests to work as planned. Unsuccessfully.
leonpolak 811643d
Synchronizing package.json with master
leonpolak 6d771f9
Merge branch 'master' into client-tests
leonpolak 1773d81
Cnanging the test to use the new metacom/lib/client.js
leonpolak File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,158 @@ | ||
'use strict'; | ||
|
||
const metatests = require('metatests'); | ||
const { Metacom } = require('metacom/lib/client'); | ||
|
||
let token = ''; | ||
|
||
const runTests = (client) => { | ||
metatests.testAsync('system/introspect', async (test) => { | ||
const introspect = await client.socketCall('system')('introspect')([ | ||
'auth', | ||
'console', | ||
'example', | ||
'files', | ||
'test', | ||
]); | ||
test.strictSame(introspect?.auth?.restore?.[0], 'token'); | ||
test.end(); | ||
}); | ||
|
||
metatests.testAsync('example/add', async (test) => { | ||
const add = await client.socketCall('example')('add')({ a: 1, b: 2 }); | ||
test.strictSame(add, 3); | ||
test.end(); | ||
}); | ||
|
||
metatests.testAsync('example/citiesByCountry', async (test) => { | ||
const cities = await client.socketCall('example')('citiesByCountry')({ | ||
countryId: 1, | ||
}); | ||
test.strictEqual(cities?.result, 'success'); | ||
test.strictEqual(Array.isArray(cities?.data), true); | ||
test.end(); | ||
}); | ||
|
||
metatests.testAsync('example/customError', async (test) => { | ||
try { | ||
await client.socketCall('example')('customError')(); | ||
leonpolak marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} catch (customError) { | ||
test.errorCompare(customError, new Error('Return custom error', 12345)); | ||
test.strictEqual(customError?.code, 12345); | ||
} finally { | ||
test.end(); | ||
} | ||
}); | ||
|
||
metatests.testAsync('example/customException', async (test) => { | ||
try { | ||
await client.socketCall('example')('customException')(); | ||
leonpolak marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} catch (customError) { | ||
test.errorCompare(customError, new Error('Custom ecxeption', 12345)); | ||
test.strictEqual(customError?.code, 12345); | ||
} finally { | ||
test.end(); | ||
} | ||
}); | ||
|
||
metatests.testAsync('example/error', async (test) => { | ||
try { | ||
await client.socketCall('example')('error')(); | ||
leonpolak marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} catch (Error) { | ||
test.errorCompare(Error, new Error('Return error')); | ||
} finally { | ||
test.end(); | ||
} | ||
}); | ||
|
||
metatests.testAsync('example/exception', async (test) => { | ||
try { | ||
await client.socketCall('example')('exception')(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ditto There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would like to catch an exception to check the message and custom data in custom exceptions and errors |
||
} catch (Error) { | ||
test.errorCompare(Error, new Error('Example exception')); | ||
} finally { | ||
test.end(); | ||
} | ||
}); | ||
|
||
metatests.testAsync('example/getClientInfo', async (test) => { | ||
try { | ||
const info = await client.socketCall('example')('getClientInfo')(); | ||
test.strictEqual(info?.result?.ip, '127.0.0.1'); | ||
test.strictEqual(info?.result?.token, token); | ||
test.strictEqual(info?.result?.accountId, '2'); | ||
} catch (Error) { | ||
console.log(Error); | ||
leonpolak marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} finally { | ||
test.end(); | ||
} | ||
}); | ||
|
||
tshemsedinov marked this conversation as resolved.
Show resolved
Hide resolved
|
||
metatests.testAsync('example/redisSet + redisGet', async (test) => { | ||
try { | ||
const setting = await client.socketCall('example')('redisSet')({ | ||
key: 'MetarhiaExampleTest', | ||
value: 1, | ||
}); | ||
const getting = await client.socketCall('example')('redisGet')({ | ||
key: 'MetarhiaExampleTest', | ||
}); | ||
console.log('setting', setting); | ||
console.log('getting', getting); | ||
} catch (Error) { | ||
test.errorCompare(Error, new Error('Example exception')); | ||
} finally { | ||
test.end(); | ||
} | ||
}); | ||
|
||
metatests.testAsync('example/resources', async (test) => { | ||
try { | ||
const resources = await client.socketCall('example')('resources')(); | ||
console.log(resources); | ||
} catch (Error) { | ||
console.log(Error); | ||
} finally { | ||
test.end(); | ||
} | ||
}); | ||
|
||
metatests.testAsync('example/wait', async (test) => { | ||
try { | ||
const wait = await client.socketCall('example')('wait')({ delay: 1000 }); | ||
test.strictEqual(wait, 'done'); | ||
} catch (Error) { | ||
console.log(Error); | ||
} finally { | ||
test.end(); | ||
} | ||
}); | ||
}; | ||
|
||
const connect = async () => { | ||
const url = 'ws://127.0.0.1:8000/api'; | ||
let client; | ||
try { | ||
client = Metacom.create(url); | ||
} catch (e) { | ||
console.log(e); | ||
} | ||
|
||
if (!client) { | ||
console.log('No client'); | ||
return; | ||
} | ||
leonpolak marked this conversation as resolved.
Show resolved
Hide resolved
|
||
await client.ready(); | ||
const signin = await client.socketCall('auth')('signin')({ | ||
login: 'marcus', | ||
password: 'marcus', | ||
}); | ||
if (typeof signin !== 'object' || signin?.status !== 'logged') { | ||
console.log('Not logged'); | ||
leonpolak marked this conversation as resolved.
Show resolved
Hide resolved
|
||
return; | ||
} | ||
token = signin?.token; | ||
runTests(client); | ||
}; | ||
|
||
connect(); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this to the
runTests
argument.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, explain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redefine
runTests
asTo get rid of global parameters.