Speaker: hide the L2ServiceStatus generation behind a flag #2312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedepaol
force-pushed
the
l2servicestatusfeatureflag
branch
from
1284f17
to
b8e62f1
Compare
Because of metallb#2311 we are going to move the status instances to the metallb namespace. This might require a change in the permissions too (from cluster to namespaced) so the new version of MetalLB might not be able to delete the "legacy" instances of the CRD because they belong to namespaces the new metallb might not have permissions on. Because of this, we hide the feature behind a flag, effectively disabling it until the issue is fixed. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
fedepaol
force-pushed
the
l2servicestatusfeatureflag
branch
from
b8e62f1
to
be4e909
Compare
We must be able to skip those tests out until metallb#2311 is fixed. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a BUG FIX or a FEATURE ?:
What this PR does / why we need it:
Because of #2311 we are going to move the status instances to the metallb namespace. This might require a change in the permissions too (from cluster to namespaced) so the new version of MetalLB might not be able to delete the "legacy" instances of the CRD because they belong to namespaces the new metallb might not have permissions on.
Because of this, we hide the feature behind a flag, effectively disabling it until the issue is fixed.
Special notes for your reviewer:
Release note: