Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor medschool to use a simple DFS #2424

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

infiniteregrets
Copy link
Member

A few important things here:

  • The earlier medschool implementation used a BtreeSet which was not required as we could simple depth first search on a vector of types with a hashmap based lookup. I intend to optimize this further so this is WIP.
  • Files are read in parallel and parsed with a threadpool, but we need to benchmark if rayon.par_into_iter is helpful without the bloat.
  • Some other improvements like squashing multiple filter_maps into a single.

WIP..

@infiniteregrets infiniteregrets marked this pull request as draft May 3, 2024 20:20
@infiniteregrets infiniteregrets marked this pull request as ready for review May 16, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant