Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump java version from 8 to 11 #345

Merged
merged 3 commits into from Mar 7, 2024
Merged

Bump java version from 8 to 11 #345

merged 3 commits into from Mar 7, 2024

Conversation

dr0i
Copy link
Member

@dr0i dr0i commented Mar 5, 2024

Resolves #343.

Consumes the rc from metafacture-core which also uses java 11.
(See metafacture/metafacture-core#515).

Consumes the rc from metafacture-core which also uses java 11.
See metafacture/metafacture-core#515 .
@dr0i dr0i requested a review from blackwinter March 5, 2024 15:52
@dr0i dr0i marked this pull request as ready for review March 5, 2024 15:53
Copy link
Member

@blackwinter blackwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should mix:

  1. Bumping the Java version,
  2. Updating the metafacture-core dependency, and
  3. Increasing the metafacture-fix version number.

This pull request is about 1. only.

Also, some tests (unit and integration) need to be updated. (Fixed in db9745b; see also 3d8d0e5.)

@blackwinter blackwinter assigned dr0i and unassigned blackwinter Mar 5, 2024
@blackwinter
Copy link
Member

blackwinter commented Mar 6, 2024

Produces warnings:

  • EqualsVerifier:

WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by nl.jqno.equalsverifier.internal.reflection.FieldModifier (file:/data/gradle/caches/modules-2/files-2.1/nl.jqno.equalsverifier/equalsverifier/3.8.2/1af9cb8854f510e42ddbcd6570212ed485a0315a/equalsverifier-3.8.2.jar) to field java.util.regex.IntHashSet.entries
WARNING: Please consider reporting this to the maintainers of nl.jqno.equalsverifier.internal.reflection.FieldModifier
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
OpenJDK 64-Bit Server VM warning: Sharing is only supported for boot loader classes because bootstrap classpath has been appended
OpenJDK 64-Bit Server VM warning: Sharing is only supported for boot loader classes because bootstrap classpath has been appended

  • Mockito:

WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.mockito.internal.util.reflection.AccessibilityChanger (file:/data/gradle/caches/modules-2/files-2.1/org.mockito/mockito-core/2.27.0/835fc3283b481f4758b8ef464cd560c649c08b00/mockito-core-2.27.0.jar) to field java.lang.Enum.name
WARNING: Please consider reporting this to the maintainers of org.mockito.internal.util.reflection.AccessibilityChanger
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

Copy link
Member

@blackwinter blackwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Since the illegal reflective access warnings are still occurring with the latest versions of EqualsVerifier (3.15.8) and Mockito (5.2.0), we might ignore them for now.

@dr0i dr0i merged commit 07d8458 into master Mar 7, 2024
1 check passed
@dr0i dr0i deleted the 343-bumpJavaTo11 branch March 7, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump java version from 8 to 11
2 participants