Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jspf cleanup #138

Merged
merged 6 commits into from
May 28, 2024
Merged

Jspf cleanup #138

merged 6 commits into from
May 28, 2024

Conversation

mayhem
Copy link
Member

@mayhem mayhem commented May 15, 2024

This PR fixes some problems with JSPF serialization:

The created_for element should be part of the extension.
track identifier should be a list not a string.

This PR must be released WITH the troi PR of the same branch name! That PR needs to be updated after this PR is merged and released.

Copy link

github-actions bot commented May 15, 2024

Test Results

  4 files  ±0    4 suites  ±0   4s ⏱️ ±0s
 50 tests ±0   50 ✅ ±0  0 💤 ±0  0 ❌ ±0 
200 runs  ±0  200 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 7b2bbca. ± Comparison against base commit b433c46.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 15, 2024

Package Line Rate Complexity Health
. 33% 0
content_resolver 0% 0
content_resolver.formats 6% 0
content_resolver.model 0% 0
external 39% 0
listenbrainz 46% 0
musicbrainz 71% 0
patches 25% 0
patches.lb_radio_classes 0% 0
tools 74% 0
. 33% 0
content_resolver 0% 0
content_resolver.formats 6% 0
content_resolver.model 0% 0
external 39% 0
listenbrainz 46% 0
musicbrainz 71% 0
patches 25% 0
patches.lb_radio_classes 0% 0
tools 74% 0
. 33% 0
content_resolver 0% 0
content_resolver.formats 6% 0
content_resolver.model 0% 0
external 39% 0
listenbrainz 46% 0
musicbrainz 71% 0
patches 25% 0
patches.lb_radio_classes 0% 0
tools 74% 0
. 33% 0
content_resolver 0% 0
content_resolver.formats 6% 0
content_resolver.model 0% 0
external 39% 0
listenbrainz 45% 0
musicbrainz 71% 0
patches 25% 0
patches.lb_radio_classes 0% 0
tools 74% 0
Summary 22% (4028 / 18032) 0

@mayhem mayhem requested a review from amCap1712 May 15, 2024 14:29
Copy link
Member

@amCap1712 amCap1712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@amCap1712 amCap1712 merged commit 9dc5882 into main May 28, 2024
6 checks passed
@amCap1712 amCap1712 deleted the jspf-cleanup branch May 28, 2024 14:41
amCap1712 added a commit that referenced this pull request May 28, 2024
See #115 for rationale.

@mayhem attempted to fix the issue in #138 again, but I got confused and
reverted it, fixing it now.
amCap1712 added a commit that referenced this pull request May 28, 2024
See #115 for rationale.

@mayhem attempted to fix the issue in #138 again, but I got confused and
reverted it, fixing it now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants