Add album_level_tags plugin #219
Conversation
Harakku
force-pushed
the
album_level_tags
branch
4 times, most recently
from
54070de
to
43e1e52
Compare
|
I just realized how this plugin could be made much cleaner. Instead of scribing down tags as they come by, an album object can be saved as a global variable. Then the album object can be accessed when the script functions are being called. Duhhh. Gonna make those changes soonish. |
Should we merge as is or do you have changes to make before? |
Harakku
force-pushed
the
album_level_tags
branch
2 times, most recently
from
44a4d6d
to
af8cf0c
Compare
New plugin to transform multiple file specific tags into single strings which are usable in the file naming script via script functions.
Harakku
force-pushed
the
album_level_tags
branch
from
af8cf0c
to
79e8a0e
Compare
|
Almost forgot to update this. The plugin has some option pages now and quite big changes in the way it works. Didn't end up needing the new hooks after all. (Awkward.) The option editing is a bit rough but I hope it's somewhat easy to understand. All in all, I'm happy with the plugin now. |
|
|
||
| # Check if cached data is recent enough to be used (i.e. we can assume that the user hasn't modified the tags | ||
| # in the meantime) or remove other releases from the cache to keep it small | ||
| global tag_cache |
There was a problem hiding this comment.
global keyword isn't strictly needed here I think.
| t = time.time() | ||
|
|
||
| cached_results = album_cache.get((metadata_key, option_profile)) | ||
| if cached_results and t - last_run_time < 4: # seconds |
There was a problem hiding this comment.
I'd replace 4 with a explicit variable/constant (something like DELAY_IN_SECONDS) and remove the comment.
| global last_run_time | ||
| album_cache = tag_cache.get(album.id, {}) | ||
| if album_cache: | ||
| t = time.time() |
There was a problem hiding this comment.
Instead of t, I'd use now or current_time since it stores current time.
|
|
||
| if option_profile is not None and option_profile not in all_user_options: | ||
| raise KeyError("{0}: Unknown option profile \"{1}\" used in a script.".format(PLUGIN_NAME, option_profile)) | ||
| if profile_options.get(FORMATTER_WHEN_ONE_OPTION): |
There was a problem hiding this comment.
Perhaps:
formatter2_is_default = False if profile_options.get(FORMATTER_WHEN_ONE_OPTION) else TrueSince you're using few of those below.
| group_by_medium = True if metadata_key == "media" else False | ||
| discnumber = 0 | ||
| temp = defaultdict(list) | ||
| for t in album.tracks: |
|
|
||
| if average_mode: | ||
| tag_counter = Counter({ sum(map(float, tag_list)) / len(tag_list): 1 | ||
| for tag_list in temp.values() if len(tag_list) > 0 }) |
There was a problem hiding this comment.
This expression deserves at least a comment, you may also cache len(tag_list).
|
|
||
| # Effectively removes the None key from the counter | ||
| tag_counter[None] = 0 | ||
| tag_counter = +tag_counter |
| text_area = self.ui.plainTextEdit_raw_2 | ||
| label = self.ui.label_valid_raw_2 | ||
| try: | ||
| _ = json.loads(text_area.toPlainText()) |
There was a problem hiding this comment.
Please avoid the use of _, it is reserved for gettextization (see https://github.com/metabrainz/picard/blob/master/picard/i18n.py)
| ) | ||
| from PyQt5 import QtGui | ||
| from PyQt5.QtWidgets import QButtonGroup | ||
| import time |
There was a problem hiding this comment.
You might want to re-order imports to fit usual Picard import order (see https://github.com/metabrainz/picard/blob/master/CONTRIBUTING.md and search for isort).
|
I can't help but wonder whether it might be better for this plugin simply to calculate the lists and averages of various file metadata and place them in the album metadata as new variables. |
New plugin to transform multiple file specific tags into single
strings which are usable in the file naming script via script
functions.