Jspf cleanup #2872
Merged
Jspf cleanup #2872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amCap1712
reviewed
May 26, 2024
amCap1712
reviewed
May 28, 2024
|
Sorry for this sloppyness. Can you tell my heart wasn't into this? |
|
Sorry for the initial confusion. fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some problems with JSPF serialization:
This PR corrects the problems above, but still allows playlists in the old format to be submitted. All code fragments for this have been marked with a date, allowing us to clean this code up in a year.
This PR must be released WITH the troi PR of the same branch name!
TODO: Update the Troi release before merging.