-
-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor HueSound into a functional component #2853
Conversation
+ rename from ColorPlay to HueSound
+Reorganize BrowserRouter so that ToastContainer has router context
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! The PR looks really good, just some small changes left.
Can't click on elements rendered on a canvas in tests, so pass an optional color + finishing tests
Replace the initialColor prop I had put in to be able to run tests, and instead test with the router and URL params directly
I ended up refactoring a bit more to allow having a color in the URL params. That way it also makes it possible to test the component, because we can't interact with the colorwheel (rendered canvas) in tests to select a color. |
Note that this component is refactored to play nice with react-router, but has not been refactored to be used with the new BrainzPlayer with queues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Based on the userfeed-refactor branch, wait for #2844 to be merged please