-
-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LB-1508 Allow hiding personal recommendations #2808
base: master
Are you sure you want to change the base?
LB-1508 Allow hiding personal recommendations #2808
Conversation
Hello @Sumit1797! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-03-12 11:37:08 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Sorry for the delay. I just came across this PR. Can you please add tests for the feature as well?
Ping @Sumit1797 |
Hi I missed the requested changes, I will updated the PR. |
Problem
A user can hide recommendations received from another user but not personal recommendations.
(https://tickets.metabrainz.org/browse/LB-1508?filter=12410)
Solution
Add the ability to hide personal recommendations
Action
Change the backend api user_timeline_event_api to add an entry for personal recommendations in the hide_timeline_events table in database.