Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Add support for default keyboard in composition view #268

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

blazer82
Copy link

Summary

This fixes #76 by implementing the proposed solution to make the keyboard type configurable in the app's preferences.

Other Information

@alexbbrown
Copy link

alexbbrown commented Nov 28, 2022

I think it's a mistake to include the name of the other site in this code and UI?

Let's refer to the actual user experience here, not a different branded product.

I think "keyboard with hash" would do the job.

@blazer82
Copy link
Author

I think it's a mistake to include the name of the other site in this code and UI?

@alexbbrown although it’s the official name of the keyboard, I kind of agree with you. We should come up with a better description. I’m also not that convinced of just calling the default keyboard default because in this app it’s specifically not the default. Somewhat confusing.

I’m open to suggestions.

@alexbbrown
Copy link

alexbbrown commented Nov 29, 2022

How about the UI preference selects between "Twitter style" and "System"

By analogy with the Appearance mode choice of System|Light|Dark

or alternatively focus on how the user experiences it:

Keyboard : "with #" / "with ⏎"

@blazer82
Copy link
Author

How about the UI preference selects between "Twitter style" and "System"

still has the name Twitter in it.

Keyboard : "with #" / "with ⏎"

I kinda like it but my screen reader doesn't. It just skips over the most important parts. This wouldn't be good for accessibility.

We should probably spell it out as you did with your initial suggestion: with hash / with return key
Hopefully, this won't be too hard to translate to all the supported languages.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace hashtag button with Enter while composing toot
2 participants