Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some quality issues, add .deepsource.toml #74

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

allenjseb
Copy link

@allenjseb allenjseb commented Feb 14, 2020

Background

DeepSource is a free for open-source tool that helps developers and teams write good code. It continuously analyzes code changes on every PR and gives a central dashboard to see code health in terms of issues and important metrics. DeepSource is used by teams at Uber, NASA and DGraph among others.
I've added a customized .deepsource.toml file for this repo, and made some fixes for issues existing in the code highlighted by DeepSource. To keep analyzing code on every change, integration is easy:

  1. Merge this PR.
  2. Sign up on DeepSource and grant access to this repository here.
  3. Activate analysis for this repo here.
    You can also take a look at the docs. I'll be happy to answer any questions! :

Changes

  1. Remove the unnecessary use of [:] in the following usage:
json := string(bytes[:])
  1. Use an unused error.

Signed-off-by: Allen allen@deepsource.io

Signed-off-by: Allen <allen@deepsource.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant