Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the whatsapp sandbox functionality #87

Merged

Conversation

jagjeetdhaliwal
Copy link

@jagjeetdhaliwal jagjeetdhaliwal commented Nov 13, 2020

The WhatsApp Sandbox has been properly integrated into Conversations API, so it shouldn't be accessed directly.

@ahmetkocadogan
Copy link
Contributor

@jagjeetdhaliwal Is this a community contribution?

@jagjeetdhaliwal
Copy link
Author

@ahmetkocadogan No :) Just updating the SDK internally to remove some of the functionality. Essentially reverting - #61

@ahmetkocadogan
Copy link
Contributor

@jagjeetdhaliwal ok :)
This will be a breaking change for my bot framework adapter, that's why I ask. I'll keep tracking nuget release of this sdk.
https://github.com/BotBuilderCommunity/botbuilder-community-dotnet/tree/develop/libraries/Bot.Builder.Community.Adapters.MessageBird

@rjelierse
Copy link

@ahmetkocadogan hi :-) I'm the dev that wrote the Sandbox. You should be able to continue using the SDK without the feature toggle (that's the only change), the underlying API will function as is. We only needed the flag, because at the time, the WhatsApp Sandbox was a PoC and not yet integrated into the Conversations API. I think the same will apply to your bot adapter. You could choose to simply ignore the value on the adapter options if you don't want to introduce a breaking change.

@ahmetkocadogan
Copy link
Contributor

@rjelierse Hello. I tried it without the flag and I couldn't use whatsapp sandbox, it was yesterday after I see this PR.

My adapter is already released via nuget, so I'll update it when you make a new release of this c# sdk.

@epels epels merged commit 0c5bbd1 into messagebird:master Nov 16, 2020
@ahmetkocadogan
Copy link
Contributor

@rjelierse I reflected this update to my adapter.

BotBuilderCommunity/botbuilder-community-dotnet#342

fyi.

@ahmetkocadogan
Copy link
Contributor

@rjelierse can you kindly check this issue #89 ?

WhatsApp sandbox does not work with v3 of this sdk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants