Added support for request timeout #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kwaazaar thanks for opening a pull request (and sorry it's taken so long for us to reply). We'll review your code next week and get back to you with any feedback we have. |
epels
suggested changes
Jul 11, 2018
| } | ||
|
|
||
| public RestClient(string accessKey, IProxyConfigurationInjector proxyConfigurationInjector) | ||
| : this(HttpsRestMessagebirdComEndpoint, accessKey, proxyConfigurationInjector) | ||
| : this(accessKey, proxyConfigurationInjector, TimeSpan.FromSeconds(60)) |
There was a problem hiding this comment.
I think it would be great to have a TimeSpan DefaultTimeout field to use here - then we can reuse that below when actually setting the timeout in PrepareRequest. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the webrequest object (.net object used to make the actual api calls) does not have a request timeout explicitly set, thus using the default timeout of 60 seconds. However, for many calls this is too much, especially when a service using the client itself uses a smaller timeout. This PR makes it possible to configure this request timeout on a Client object.