Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prettier config #77

Closed
wants to merge 1 commit into from
Closed

Conversation

jcbhmr
Copy link
Collaborator

@jcbhmr jcbhmr commented Jun 6, 2023

Going based on this sentiment:

So I just chose, there's nothing you can't do with named exports, so why not only use named exports. It's all about reducing options and streamlining, unifying, calming the mind. ;)
#60 (comment)

Reducing the amount of customization seems like a good idea. Prettier themselves even recommend against modifying the config! 馃槉

By far the biggest reason for adopting Prettier is to stop all the ongoing debates over styles.
https://prettier.io/docs/en/option-philosophy.html

Sidenote: Prettier auto-includes any prettier-plugin-* packages, so you don't need the plugins: [] option at all

@jcbhmr jcbhmr requested a review from mesqueeb June 6, 2023 21:51
@jcbhmr jcbhmr self-assigned this Jun 6, 2023
@jcbhmr
Copy link
Collaborator Author

jcbhmr commented Jun 6, 2023

IMO the default options are pretty universal. You never have to think about it again. No configuring, just npx prettier -w . and you're done. I really wish they respected the .gitignore so I didn't have to do --ignore-path .gitignore though to avoid formatting dist 馃槶

@jcbhmr
Copy link
Collaborator Author

jcbhmr commented Jun 6, 2023

In the future, @mesqueeb you might want to consider adopting a widespread eslint config preset like:

Or make your own! 馃コ

@jcbhmr
Copy link
Collaborator Author

jcbhmr commented Jul 17, 2023

Sidenote: prettier just released Prettier v3! https://prettier.io/blog/2023/07/05/3.0.0.html

@mesqueeb
Copy link
Owner

will close this one in favour of bb6c47e

Not ready yet to get rid of prettier config sorry 馃槄 life's too short to look at semicolons.

Looked into a couple of eslint tools / plugins, decided to go with eslint-plugin-unicorn
I bundled everything at @cycraft/eslint

@mesqueeb mesqueeb closed this May 24, 2024
@mesqueeb mesqueeb deleted the remove-prettier-config branch May 24, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants