Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dist folder #76

Open
wants to merge 1 commit into
base: node-gitignore
Choose a base branch
from
Open

Remove dist folder #76

wants to merge 1 commit into from

Conversation

jcbhmr
Copy link
Collaborator

@jcbhmr jcbhmr commented Jun 6, 2023

馃洃 DONT MERGE THIS UNTIL #59 is merged to main!

This PR would require node-gitignore #59 to be merged first since it's dependant on that ignore rule for the dist foldr.

This PR would...

  • Delete the dist folder

This would simplify things going forward so that there is one and only one canonical copy of source code in the Git source tree.

@jcbhmr jcbhmr self-assigned this Jun 6, 2023
@jcbhmr
Copy link
Collaborator Author

jcbhmr commented Jun 6, 2023

If you still want a preview of "what will the JS be?" then you can add a preview-pack.yml or similar that runs npm pack and uploads the .tar.gz as an artifact.

IMO I don't think this is needed though since TS corresponds 1:1 with JavaScript in all cases. It's designed to. The only thing that changes is types get stripped out into a .d.ts file. ...That is if you use --target ESNext 馃槈 -- if you use --target ES5, it'll behave the same just with some polyfill magic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant