build(deps): bump controller-runtime to v0.14.6 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takirala
force-pushed
the
tga/bump-controller-runtime
branch
from
cff38e3
to
36de4db
Compare
Signed-off-by: Tarun Gupta Akirala <takirala@users.noreply.github.com>
takirala
force-pushed
the
tga/bump-controller-runtime
branch
from
e37bbec
to
e397c1a
Compare
takirala
changed the title
cbuto
approved these changes
Apr 4, 2023
Signed-off-by: Tarun Gupta Akirala <takirala@users.noreply.github.com>
takirala
commented
Apr 4, 2023
| @@ -44,8 +42,6 @@ import ( | |||
| ) | |||
|
|
|||
| func main() { | |||
| rand.Seed(time.Now().UnixNano()) | |||
There was a problem hiding this comment.
this is fine cuz acc. to golang/go#54880 global generator is seeded at startup i think.
also i couldnt find any references as to why this is needed here but even if its used this change is fine i think
Signed-off-by: Tarun Gupta Akirala <takirala@users.noreply.github.com>
Signed-off-by: Tarun Gupta Akirala <takirala@users.noreply.github.com>
Signed-off-by: Tarun Gupta Akirala <takirala@users.noreply.github.com>
sonofgibs
approved these changes
Apr 5, 2023
Signed-off-by: Tarun Gupta Akirala <takirala@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Bumps controller runtime to latest version
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer: