do @ substitution for normal cmake format, separate cmakedefine and mesondefine logic #13208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the compilation errors appear unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows upstream cmake, see configure_file.
cmake substitutes
${VAR}and@VAR@by default and only@VAR@if@ONLYis specified.meson previously substituded
${VAR}withcmakeand@VAR@withcmake@but this has now been fixed so thatcmakealso substitudes@VAR@.Ontop of that I also split most of the cmakedefine and mesondefine code into specific functions so changes to either won't cause regressions in the other (as the previous cmakedefine PR did).
work was done to ensure all the exported interfaces continue being available.
cmakedefine was tested using cmakedefine-test and mesondefine was tested using the
AllPlatformTests.test_do_conf_file_by_formatunit test.