Add specific dependency handling for clang #13134
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The poorly named `print_tool_versions()` doesn't just print the tools versions, it finds them and populates a global table, without which some tests will fail. Rename the function and add a `report` argument so that calls can decide whether they want to have the printed message, because the single runner doesn't in quick mode.
Clang has two ways to be found, CMake, and by hand. Clang has some hurdles of use because of the way it's installed on many Linux distros, either in a separate prefix, in a prefix with LLVM, or in a common prefix, which requires some amount of effort to make it work. TODO: tests for C++ TODO: fill out skip expectations on various CI platforms…
dcbaker
force-pushed
the
submit/clang-dep
branch
from
81506a3
to
ab5966d
Compare
tristan957
reviewed
Apr 23, 2024
Comment on lines
+617
to
+618
| Both libclang (the C interface) and the C++ interfaces are supported via the | ||
| `language` keyword. The default is to search for the `C++` interface. |
There was a problem hiding this comment.
I don't understand why we can't do this for Rust dependencies, @xclaesse.
| Clang modules are supported, and must be passed in the format `clangBasic`, with | ||
| proper capitalization and the `clang` prepended. | ||
|
|
||
|
|
There was a problem hiding this comment.
Would be good to add an example of how to use modules above ^
|
|
||
| modules = stringlistify(extract_as_list(kwargs, 'modules')) | ||
| if not modules and language == 'cpp': | ||
| mlog.warning('Clang dependency without modules works correctly for dynamically linked Clang, ' |
There was a problem hiding this comment.
casing on 'clang' seems inconsistent
There was a problem hiding this comment.
Perhaps a comment here would be good because I am not understanding the language check
| # Version.h is a C++ header, and this will fail if we look | ||
| # for clang-c. The inc is just the basic | ||
| version = self.clib_compiler.get_define('CLANG_VERSION', '#include <clang/Basic/Version.inc>', env, lib, self.ext_deps)[0] | ||
| if not self.version_reqs or (mesonlib.version_compare_many(version, self.version_reqs)): |
Comment on lines
+592
to
+595
| if not modules: | ||
| return | ||
| if language != 'cpp': | ||
| return |
|
/cc @thesamesam |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang is fun. It has a C API library and C++ API libraries. It has the following configurations that need to be accounted for:
On top of that, to get the Clang Version for the C API you need to resort to some trickery. I've checked the implementation I came up with for clang 6-17 and it works for all of those. For the C++ API it's easy, because the header required is a C++ header.
TODO: