dependencies/openmp: more robust check for Fortran #13075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcbaker
force-pushed
the
submit/better-fortran-openmp-detection
branch
from
bd92e86
to
a97d76b
Compare
dnicolodi
reviewed
Apr 12, 2024
| @@ -6,6 +6,7 @@ | |||
|
|
|||
There was a problem hiding this comment.
I think there is a typo in the commit message which makes it hard to understand. I think "for omp_lib.h" should be "or omp_lib.h".
There was a problem hiding this comment.
Agreed, it was hard to understand. I've reworded it
Instead of looking for omp.h (which is C/C++ specific) and omp_lib.h (which is Fortran specific), just check to see if we can link an OpenMP program with Fortran.
dcbaker
force-pushed
the
submit/better-fortran-openmp-detection
branch
from
a97d76b
to
586f8e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of looking for omp.h (which is C/C++ specific) for omp_lib.h, which is only supported by some compilers, just check to see if we can link an OpenMP program with Fortran.
Specifically, on NixOS omp_lib.h is put in a difficult to find place, and I was unable to craft a reliable check that wasn't just a hack for Nix. On the other hand the link test does work reliably, and should be more reliable in general. I lifted this check from @scivision in this comment: #7017 (comment)