Ignore MQTT by default and then don't transmit downlink over LoRa #3591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wonderful! I just submitted a feature request with this exact suggestion, and tagged your PR as a probably solution to get it some attention. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements what has been discussed up till now in meshtastic/rfcs#9 and thus needs to be approved first.
The "ignore MQTT" LoRa setting will be enabled by default and this now also means if you have MQTT downlink enabled, it doesn't transmit these packets over LoRa. MQTT-only will work as before and if you also want your mesh to receive the downlinks, you have to explicitly disable "ignore MQTT".
Tested both that MQTT downlink works and also ignoring MQTT works as before.