Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds basic PNG download #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adds basic PNG download #39

wants to merge 1 commit into from

Conversation

HansNewbie
Copy link

#32

Adds basic PNG download.

  • Need suggestion if we can use DOM in the React. While it's not a good React practice, the other option that I know of is to use jsdom which seems to be too much.
  • Right now I hard coded the canvas size. Let me know how to approach this best.

@knsv
Copy link
Contributor

knsv commented Nov 17, 2019

Thhank you for this update. I am reworking the editor to use a text editor with syntax highlighting. With that these changes will be gone. I will however copy /paster you onDowonloadPng into the new code base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HansNewbie @knsv