Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move error dialogue to bottom of editor. #1299

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

sidharthv96
Copy link
Member

@sidharthv96 sidharthv96 commented Sep 15, 2023

📑 Summary

The error dialogue is moved to the bottom of editor.

Resolves #

📏 Design Decisions

This is an adaptation of work done by @huynhicode and @pbrolin47 at MermaidChart.
image

image

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

@netlify
Copy link

netlify bot commented Sep 15, 2023

Deploy Preview for mermaidjs ready!

Name Link
🔨 Latest commit bb526e1
🔍 Latest deploy log https://app.netlify.com/sites/mermaidjs/deploys/65127d382f6a490008ae0f81
😎 Deploy Preview https://deploy-preview-1299--mermaidjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress
Copy link

cypress bot commented Sep 15, 2023

1 failed test on run #1129 ↗︎

1 27 6 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge bb526e1 into 8338290...
Project: Mermaid Live Editor Commit: 2b03c68d4c ℹ️
Status: Failed Duration: 04:00 💡
Started: Sep 26, 2023 6:43 AM Ended: Sep 26, 2023 6:47 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link

This pr is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days

@github-actions github-actions bot added the Stale label Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant