refactor: Use timezone-aware datetime objects #8265
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meltano canceled.
|
edgarrmondragon
force-pushed
the
refactor/datetime-tz-aware
branch
2 times, most recently
from
2cc63c2
to
8187f67
Compare
|
@edgarrmondragon Just curious, why close this? |
Noticed the attempt was too ambitious and broke some tests 😅. Looking back, it's only 8 tests so probably worth re-opening and trying to revert the offending changes. |
edgarrmondragon
force-pushed
the
refactor/datetime-tz-aware
branch
4 times, most recently
from
c8a5810
to
be2af04
Compare
edgarrmondragon
force-pushed
the
refactor/datetime-tz-aware
branch
2 times, most recently
from
85b3085
to
8d169cc
Compare
edgarrmondragon
force-pushed
the
refactor/datetime-tz-aware
branch
2 times, most recently
from
4e89598
to
b81eaef
Compare
edgarrmondragon
force-pushed
the
refactor/datetime-tz-aware
branch
5 times, most recently
from
a880320
to
f319f71
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8265 +/- ##
==========================================
+ Coverage 91.83% 91.89% +0.06%
==========================================
Files 245 246 +1
Lines 19337 19387 +50
Branches 2152 2158 +6
==========================================
+ Hits 17758 17816 +58
+ Misses 1306 1299 -7
+ Partials 273 272 -1 ☔ View full report in Codecov by Sentry. |
edgarrmondragon
force-pushed
the
refactor/datetime-tz-aware
branch
7 times, most recently
from
c110032
to
4ef5af2
Compare
edgarrmondragon
force-pushed
the
refactor/datetime-tz-aware
branch
9 times, most recently
from
b80e2e6
to
a20a2f5
Compare
edgarrmondragon
force-pushed
the
refactor/datetime-tz-aware
branch
2 times, most recently
from
cef07b4
to
388e23e
Compare
edgarrmondragon
force-pushed
the
refactor/datetime-tz-aware
branch
4 times, most recently
from
135930b
to
a72309a
Compare
edgarrmondragon
force-pushed
the
refactor/datetime-tz-aware
branch
2 times, most recently
from
4b9521f
to
88b2d85
Compare
edgarrmondragon
force-pushed
the
refactor/datetime-tz-aware
branch
2 times, most recently
from
c6bdf55
to
3e32c92
Compare
edgarrmondragon
force-pushed
the
refactor/datetime-tz-aware
branch
3 times, most recently
from
6850b90
to
381a97f
Compare
edgarrmondragon
force-pushed
the
refactor/datetime-tz-aware
branch
from
381a97f
to
47e1001
Compare
edgarrmondragon
force-pushed
the
refactor/datetime-tz-aware
branch
3 times, most recently
from
e3a248b
to
3558279
Compare
edgarrmondragon
force-pushed
the
refactor/datetime-tz-aware
branch
from
3558279
to
92efcab
Compare
edgarrmondragon
force-pushed
the
refactor/datetime-tz-aware
branch
from
92efcab
to
ff13c36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.