Do not access 'project.zipTree' in mapping closure #261
Conversation
There was a problem hiding this comment.
Thanks for the PR @jjohannes! Instead of creating a subtask I would simply inject ArchiveOperations in the plugin then use it in the task.
|
No problem. Happy I figured this out. I am also not super happy with the subclass. I tried injecting via the plugin already. It's not working. The service property can't be found when the code in the closure executes (if CC is turned on). I think this is, because the code executes after the state has been loaded from the cache. Which is the reason why there is a problem in the first place. At that point, the plugin context is not available anymore. |
jjohannes
force-pushed
the
fix-229
branch
2 times, most recently
from
bcf19d6
to
b4de42b
Compare
|
It can be injected via the plugin. "Just" need to store a reference in a variable while we can. Updated the PR – PTAL. |
This is not supported by the Configuration Cache. Instead, we inject an ArchiveOperations service. Fixes melix#229
|
The test also starts failing (on master) with newer Gradle versions. Not sure anymore if what was reported in #261 is exactly this issue. But in any case this is an issue with Gradle |
|
@jjohannes can you allow edits on your PR? |
Should be turned on. |
|
Strange, I get a permission denied 🤔 |
|
Strange. The flag is set here in my UI. Feel free to just copy the solution into a new PR/branch. |
|
My bad, had a typo in the branch name |
|
Thank you @melix! |
This is not supported by the Configuration Cache. Instead, we inject an ArchiveOperations service.
Fixes #229