Polish tests #65
Merged
Polish tests #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update dependency com.github.siom79.japicmp:japicmp to v0.17.3 * Polish IncompatibleChangeExclusionTest --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Goooler <wangzongler@gmail.com>
Goooler
commented
Sep 2, 2023
Comment on lines
-19
to
-33
| task japicmpDetectsNewDefaultMethodByDefault(type: me.champeau.gradle.japicmp.JapicmpTask) { | ||
| oldClasspath.from(jar) | ||
| newClasspath.from(jarv2) | ||
| failOnModification = true | ||
| failOnSourceIncompatibility = true | ||
| } | ||
|
|
||
| task configuredToIgnoreNewDefaultMethod(type: me.champeau.gradle.japicmp.JapicmpTask) { | ||
| oldClasspath.from(jar) | ||
| newClasspath.from(jarv2) | ||
| failOnModification = true | ||
| failOnSourceIncompatibility = true | ||
| compatibilityChangeExcludes = [ "METHOD_NEW_DEFAULT" ] | ||
| } | ||
|
|
There was a problem hiding this comment.
See siom79/japicmp#289.
Goooler
commented
Sep 2, 2023
| private final static GradleVersion GRADLE_MIN = GradleVersion.version("6.0"); | ||
| private final static GradleVersion GRADLE_MIN = GradleVersion.version("6.6"); |
There was a problem hiding this comment.
Some APIs like Provider.zip depend on Gradle 6.6.
Gradle intro configuration cache in 6.6, we are now on it, see https://docs.gradle.org/6.6/release-notes.html#configuration-caching. But I also notified some CC compatibility issues left in c398274, todo it.
Goooler
force-pushed
the
master
branch
2 times, most recently
from
3d8c880
to
bf6bee3
Compare
|
Thanks for the update! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #63.