Add method for creating a snapshot #508
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #508 +/- ##
=======================================
Coverage 99.62% 99.63%
=======================================
Files 9 9
Lines 540 542 +2
=======================================
+ Hits 538 540 +2
Misses 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Thank you @andre-m-dev
LGTM but I let one of the maintainers (@ellnix or @brunoocasali) review and merge it
Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
ellnix
changed the title
There was a problem hiding this comment.
LGTM, thank you for the contribution @andre-m-dev
bors merge
508: Add method for creating a snapshot r=ellnix a=andre-m-dev # Pull Request ## Related issue Fixes [504](#504) ## What does this PR do? - Add a method to create a snapshot ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Co-authored-by: Andre <> Co-authored-by: André <1729839+andre-m-dev@users.noreply.github.com>
|
This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried. Additional information: {"message":"1 review requesting changes and 1 approving review by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
|
Unfortunately it looks like we have to wait for @brunoocasali to confirm that his requested changes were addressed, I will leave merging to him. |
|
My bad, it's not about this -> it's because @brunoocasali asked for changes so we need him to approve again |
|
@ellnix if the contributor made what Bruno asked for you can
|
I didn't think that could be an option. Will do right away. |
|
bors merge |
Pull Request
Related issue
Fixes 504
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements: