Delete documents by filter #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will increase the DX when the user tries to use a route method that are not defined in the current Meilisearch instance they are using.
Regenerate rubocop_todo
|
@bidoubiwa here on the Ruby SDK, the Meili errors are always |
This was referenced May 20, 2023
Merged
curquiza
reviewed
May 22, 2023
bidoubiwa
reviewed
May 22, 2023
bidoubiwa
reviewed
May 22, 2023
brunoocasali
force-pushed
the
delete-documents-by-filter
branch
from
f002359
to
307c268
Compare
|
@bidoubiwa I'm going to merge this, and also the get_documents, since I addressed all of your concerns ;) |
meili-bors bot
added a commit
that referenced
this pull request
Jun 5, 2023
440: Update version for the next release (v0.24.0) r=brunoocasali a=meili-bot Release CHANGELOG: This version introduces features released on Meilisearch v1.2.0 🎉 Check out the changelog of [Meilisearch v1.2.0](https://github.com/meilisearch/meilisearch/releases/tag/v1.2.0) for more information on the changes.⚠️ If you want to adopt new features of this release, **update the Meilisearch server** to the according version. ### 🚀 Enhancements - The method `delete_documents()` now supports a different behavior. This method could take an `options` hash containing a `filter:` key/value object to filter the documents or a simple array or single value as usual.⚠️ Still, even being supported, the ability to receive other types than a hash is deprecated and should be changed to a filter. Please use `filter` instead. #438 `@brunoocasali` - When a query with a `filter` key is sent to `get_documents(options = {})` it will filter the documents like the `search` method. This feature requires a Meilisearch server version greater than v1.2. See [the docs on how to use filters](https://www.meilisearch.com/docs/learn/advanced/filtering#filter-basics). #439 `@brunoocasali` Thanks again to `@brunoocasali!` 🎉 Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
delete_documents()now supports a different behavior. This method could take anoptionshash containing afilter:key/value object to filter the documents or a simple array or single value as usual.Introduce a way of handling the exceptions before being raised to be able to add a custom message where we give the user a hint of where the error is (version related).
This is how the error will look like when the user tries to call a delete by filters when using an old Meilisearch version: