-
Notifications
You must be signed in to change notification settings - Fork 44
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
498: Implement new await synchronous interface r=ellnix a=ellnix # Pull Request ## Related issue Fixes #288 While refactoring, inadvertently fixes: - Fixes #499 - Fixes #500 ## PR checklist Please check if your PR fulfills the following requirements: - [X] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [X] Have you read the contributing guidelines? - [X] Have you made sure that the title is accurate and descriptive of the changes? ## Changes Checklist - [X] Add soft deprecation messages - [X] Remove bang methods from specs - [X] Add Task "model" - [X] Ensure all tests pass with edits where necessary - [X] Add tests to make sure that all bang methods actually provide deprecation warnings - [X] Return Task model on all methods that return tasks - [X] Return Task model from all settings setters and getters - [ ] Update the documentation with new syntax (if applicable) Co-authored-by: ellnix <103502144+ellnix@users.noreply.github.com>
- Loading branch information
Showing
29 changed files
with
1,832 additions
and
1,239 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.