better handling for announcements without CTAs

meetfranz · Apr 4, 2022 · e21d653 · e21d653
1 parent 9db8226
commit e21d653
Showing 1 changed file with 21 additions and 19 deletions.
diff --git a/src/features/announcements/components/AnnouncementScreen.js b/src/features/announcements/components/AnnouncementScreen.js
@@ -229,7 +229,7 @@ class AnnouncementScreen extends Component {
                       __html: marked(announcement.main.text, markedOptions),
                     }}
                   />
-                  {(announcement.main.cta.label || announcement.main.cta.href) && (
+                  {(announcement.main.cta && (announcement.main.cta.label && announcement.main.cta.href)) && (
                     <div className={classes.mainCtaButton}>
                       <Button
                         label={announcement.main.cta.label}
@@ -265,25 +265,27 @@ class AnnouncementScreen extends Component {
                       __html: marked(announcement.spotlight.text, markedOptions),
                     }}
                   />
-                  <div className={classes.mainCtaButton}>
-                    <Button
-                      label={announcement.spotlight.cta.label}
-                      onClick={() => {
-                        const {
-                          analytics,
-                          href,
-                          label,
-                        } = announcement.spotlight.cta;
-                        if (announcement.spotlight.cta.href.startsWith('http')) {
-                          actions.app.openExternalUrl({ url: href });
-                        } else {
-                          window.location.href = `#${href}`;
-                        }
+                  {announcement.spotlight.cta && (
+                    <div className={classes.mainCtaButton}>
+                      <Button
+                        label={announcement.spotlight.cta.label}
+                        onClick={() => {
+                          const {
+                            analytics,
+                            href,
+                            label,
+                          } = announcement.spotlight.cta;
+                          if (announcement.spotlight.cta.href.startsWith('http')) {
+                            actions.app.openExternalUrl({ url: href });
+                          } else {
+                            window.location.href = `#${href}`;
+                          }
 
-                        gaEvent(analytics.category, analytics.action, label);
-                      }}
-                    />
-                  </div>
+                          gaEvent(analytics.category, analytics.action, label);
+                        }}
+                      />
+                    </div>
+                  )}
                 </div>
               </div>
             )}