New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
video room plugin: introduced string_ids_user #3369
base: master
Are you sure you want to change the base?
Conversation
Thanks for your contribution, @IgorKhomenko! Please make sure you sign our CLA, as it's a required step before we can merge this. |
I see many problems in this patch:
As such, this patch needs a lot of fixing IMHO before we can review/test it. While it's ok to use the dedicated booleans for the checks, these should all be configurable via the configuration file, and when the new properties are not provided, the old |
1 - this is addressed and pushed |
I don't see this possibility: |
@IgorKhomenko did you have a chance to revisit the PR with the changes I suggested? |
Issue reference #3364 (comment)