Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

janus.js: "connectionState" callback added #3343

Merged
merged 1 commit into from Mar 29, 2024

Conversation

RSATom
Copy link
Contributor

@RSATom RSATom commented Mar 11, 2024

it can be useful since latest Chrome versions
doesn't assign failed state to ICE connection state.

@lminiero
Copy link
Member

Just an editorial note: maybe pcState would be a shorter and "better" name? We already shorten PeerConnection to pc in other places (e.g., pcStuff), and the other state related callbacks have a short name too. Or maybe let's just call it connectionState, since that's what the actual callback is?

@RSATom
Copy link
Contributor Author

RSATom commented Mar 12, 2024

I've thought about using connectionState but worried it can be confusing for users since they can think it's related to http/WebSockets connection. But if you think it's ok - I'll change it.

And I don't like too significant abbreviation (I'm about pcState) but anyway it's up to you what exactly to choose - I'm ok with anything allowing me to fix issue :) - just tell me what you prefer...

it can be useful since latest Chrome versions
doesn't assign `failed` state to ICE connection state.
@RSATom RSATom changed the title janus.js: peerConnectionState callback added janus.js: "connectionState" callback added Mar 15, 2024
@RSATom
Copy link
Contributor Author

RSATom commented Mar 15, 2024

@lminiero FYI peerConnectionState -> connectionState (and the same for #3342 )

@lminiero lminiero merged commit 9c6ec96 into meetecho:master Mar 29, 2024
2 of 8 checks passed
@RSATom RSATom deleted the peerConnectionState branch April 2, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants