Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stuck sip sessions #3333

Closed
wants to merge 1 commit into from

Conversation

Jonbeckas
Copy link

Structural not compleatly clean, but it should fix issue #3332

@januscla
Copy link

Thanks for your contribution, @Jonbeckas! Please make sure you sign our CLA, as it's a required step before we can merge this.

@lminiero
Copy link
Member

I haven't investigated the issue yet, but I don't think this is a proper fix. Resetting a PeerConnection state in the Janus core is not simply a matter of clearing a flag: there are steps that must be traversed. If you're not getting the PC closed, then maybe the plugin is not closing the PC, so it's the SIP plugin that should be updated, not the core.

@Jonbeckas
Copy link
Author

I don't think it is possible to fix this only in the sip_plugin, because the hangup event is not fired, because the session still has the flag JANUS_ICE_HANDLE_WEBRTC_ALERT when no sdp was send yet.
It's possible to fix it just in the sip_plugin if we set session->establishing to 0 on decline, but it would be a duplication with the later called hangup function.

@Jonbeckas Jonbeckas closed this Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants