Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update demos and docs to Bootstrap 5.x #3300

Merged
merged 9 commits into from Dec 6, 2023
Merged

Update demos and docs to Bootstrap 5.x #3300

merged 9 commits into from Dec 6, 2023

Conversation

lminiero
Copy link
Member

This is a proper refactoring of all the demos and the generated documentation so that it uses more up-to-date stuff, specifically Bootstrap 5.x, which #3295 and #3296 did incorrectly. The patch also updates font-awesome to 6.x, so it already includes (and actually expands, since there was stuff that was incorrect there too) #3298. Notice I will only do this for master: all the 0.x demo/docs will remain as they are.

This required a huge effort, since I first needed to migrate to Bootstrap 4.x (which took quite a while), and from there to 5.x (less problematic but still not a walk in the park). I tried testing all demos in multiple scenarios, but obviously I couldn't test everything, so please give them a go yourself too just to ensure I didn't break anything in the process. From a functional perspective, everything should be there.

Before merging, I'll try to also try and take advantage of a few things that Bootstrap has, but that we're relying on external libraries for, like spinners and toasts. Ideally that should help us getting closer to get rid of jQuery, even though that will take longer, and will done (in case) in a separate PR, since we depend on it for some stuff (BlockUI, all selectors, all html appends/prepends and maybe a few other things).

Feedback welcome!

@lminiero lminiero added the multistream Related to Janus 1.x label Nov 29, 2023
@lminiero
Copy link
Member Author

Pinging @bkmgit since he was the author of the original efforts.

@lminiero
Copy link
Member Author

lminiero commented Dec 6, 2023

Merging.

@lminiero lminiero merged commit 5cc6c6c into master Dec 6, 2023
8 checks passed
@lminiero lminiero deleted the bootstrap-v5 branch December 6, 2023 15:32
@bkmgit
Copy link
Contributor

bkmgit commented Dec 6, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multistream Related to Janus 1.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants