Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pp-av1: use obuparse #3227

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

tmatth
Copy link
Contributor

@tmatth tmatth commented May 29, 2023

WIP

Currently a discrepancy after ever "Detected new resolution", size is 1 less and header type is 2 instead of 6:

image

Upstream is here: https://github.com/dwbuiten/obuparse
License is permissve (ISC)

@lminiero
Copy link
Member

That looks like a lot of additional code, and I'm not sure if there's a reason for it: after all, the post-processor code mostly only cares about OBU when figuring out the resolution, and only in part for depacketization. For that, isn't our simpler code enough? Besides, to be honest I'm not sure I'm comfortable embedding a bunch of external code I'd then have to keep up to date with: I went through that with Duktape in the past and it was a mess, and in fact we changed that to an external dependency to be installed separately.

@tmatth
Copy link
Contributor Author

tmatth commented May 29, 2023

That looks like a lot of additional code, and I'm not sure if there's a reason for it: after all, the post-processor code mostly only cares about OBU when figuring out the resolution, and only in part for depacketization. For that, isn't our simpler code enough? Besides, to be honest I'm not sure I'm comfortable embedding a bunch of external code I'd then have to keep up to date with: I went through that with Duktape in the past and it was a mess, and in fact we changed that to an external dependency to be installed separately.

@lminiero I marked this as draft as I'm not sure if it's worth merging it yet. I also want to validate the existing parsing.

@lminiero
Copy link
Member

Ack, I'll wait for more feedback then, thanks for the clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants